Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: describe schemas in the DSL #78

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Conversation

MShahzaib
Copy link
Contributor

@MShahzaib MShahzaib commented Jun 23, 2022

Closes #13.

Summary of Changes

  • added "schema" declaration to grammar for describing a dataset's initial schema
  • added ".sdsschema" extension for schemas

@MShahzaib MShahzaib requested a review from lars-reimann as a code owner June 23, 2022 16:14
@github-actions
Copy link

github-actions bot commented Jun 23, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 2.97s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 1 0 0 1.42s
✅ JSON jsonlint 1 0 0.35s
✅ JSON prettier 2 0 0 1.07s
✅ JSON v8r 1 0 5.49s
✅ KOTLIN ktlint 8 0 0 22.45s
✅ MARKDOWN markdownlint 1 0 0 0.58s
✅ MARKDOWN markdown-link-check 1 0 0.72s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough work, just two small changes required (see other comments).

Also, for the future: Please also keep larger refactorings that are unrelated to the current feature (like changing the names of predicates to lowercase) in a separate PR. It's alright this time, though.

@lars-reimann lars-reimann changed the title feat: Describe schemas in the DSL (#13) feat: describe schemas in the DSL Jun 23, 2022
@MShahzaib MShahzaib force-pushed the feat_Describe_schema_in_DSL branch 2 times, most recently from cda2506 to e62f101 Compare June 29, 2022 09:30
Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lars-reimann lars-reimann enabled auto-merge (squash) June 29, 2022 10:02
@lars-reimann lars-reimann merged commit 82b1b41 into main Jun 29, 2022
@lars-reimann lars-reimann deleted the feat_Describe_schema_in_DSL branch June 29, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Describe schemas in the DSL
2 participants