-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subgroup intrinsics #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
force-pushed
the
subgroup2
branch
from
September 20, 2024 11:31
2502eb1
to
613e249
Compare
Firestar99
requested review from
eddyb,
LegNeato and
fornwall
as code owners
September 20, 2024 11:36
I thought we had a ScalorOrVector trait already but looks like it never landed: It is slightly different, perhaps they should be the same? |
Firestar99
force-pushed
the
subgroup2
branch
from
September 23, 2024 09:26
613e249
to
a7390b2
Compare
I've rebased and made the |
fee1-dead
reviewed
Sep 23, 2024
Firestar99
force-pushed
the
subgroup2
branch
from
September 23, 2024 09:44
a7390b2
to
528fd47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #12 #13 to be merged first
Adds support for subgroup intrinsics, see GL_KHR_shader_subgroup and SPIRV spec 3.49.24. Non-Uniform Instructions.
Note that the glsl extension only exposes spirv's
OpGroupNonUniform*
instructions, and NOT theOpGroup*
instructions which can be found in 3.49.21. Group and Subgroup Instructions. As manyOpGroup*
instructions are only documented withReserved.
, I assume during development they decided against these and switched to theOpGroupNonUniform*
instructions.Open Questions:
OpGroupNonUniform*
, glsl calls themsubgroup*
. I've decided to name themsubgroup_non_uniform*
but I'm wondering if thenon_uniform
should be dropped as they all are non uniform? Resolved: Dropped thenon_uniform
, all are now namedsubgroup_*
like glsl.trait VectorOrScalar
. But glam's boolean vectors seem to behave weirdly and not work, not even the compiletestarch/any
uses them. Resolved: For now I've just left them unsupported.