Shader crate cargo features #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
force-pushed
the
shader-crate-cargo-features
branch
2 times, most recently
from
4f65bbd to
1b7740c
Compare
Firestar99
requested review from
eddyb,
LegNeato and
fornwall
as code owners
Merged
LegNeato
approved these changes
Sep 21, 2024
Firestar99
force-pushed
the
shader-crate-cargo-features
branch
from
1b7740c to
0ae6c4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #12 to be merged first
Adds fields for default-features and features to SpirvBuilder [and] pipes those fields through to the cargo command that builds the shader crate.
Original PR in embark's repo