-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: workflow status listener - RK-19190 #85
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
279659c
feat: workflow status listener
gosharo be9e26b
fix: update file struct
gosharo 0a502ec
fix: change naming
gosharo e167b81
fix: add github status
gosharo 7d9c8d3
fix: create github notifier
gosharo ab1ee69
fix: handler removed
gosharo ccef59b
fix: e2e test to use argo right address
gosharo ceae1bd
fix: github status norifier
gosharo bbd195d
feat: update piper notify status
gosharo 47f6307
feat: move event handler to diffrent interface
gosharo 43b932a
feat: change panic to info
gosharo d315130
fix: remove unnecessary label
gosharo 74baa07
fix: seprate workflow handler to diffrent file
gosharo a90370d
fix: added tests
gosharo b59e81c
fix: fixed some test issues
gosharo b7612cb
fix: chnage piper/notify label
gosharo 4d65c3e
fix: chnage piper/notify label
gosharo 463f474
fix: code review changes
gosharo 5fc9ab3
Merge branch 'main' into event-listener
gosharo 90bc301
fix: mockGitProvider implementation mismatch
gosharo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would split the code to 2 files
event_handlers.go
piper.go (this is the main)
This way piper.go only deals with initializing stuff and not doing any actual logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already on it :D
check the new commit @qadiludmer