feat: workflow status listener - RK-19190 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonariorobot
changed the title
sonariorobot
changed the title
Signed-off-by: Gosha <[email protected]>
qadiludmer
reviewed
Jul 6, 2023
cmd/piper/piper.go
Outdated
| //if err != nil { | ||
| // panic(err) | ||
| //} | ||
| ctx := context.Background() |
There was a problem hiding this comment.
I would split the code to 2 files
event_handlers.go
func HandleWorkflowEvents(workflowClient) {
// create the watch and start listening to events and also handling them
}piper.go (this is the main)
go HandleWorkflowEvents(globalClients.Workflows)This way piper.go only deals with initializing stuff and not doing any actual logic
There was a problem hiding this comment.
already on it :D
check the new commit @qadiludmer
Signed-off-by: Gosha <[email protected]>
Signed-off-by: Gosha <[email protected]>
qadiludmer
reviewed
Jul 6, 2023
pkg/event_handler/event_handler.go
Outdated
|
|
||
| type eventHandlerImpl struct{} | ||
|
|
||
| func (eh *eventHandlerImpl) handle(workflowChan <-chan watch.Event) { |
There was a problem hiding this comment.
handle should get the actual event, not the channel
qadiludmer
reviewed
Jul 6, 2023
pkg/event_handler/main.go
Outdated
|
|
||
| handlerImpl := &eventHandlerImpl{} | ||
| go func() { | ||
| handlerImpl.handle(watcher.ResultChan()) |
There was a problem hiding this comment.
here you should wait for channel data and once new data arrive pass it to the handler
qadiludmer
reviewed
Jul 6, 2023
pkg/event_handler/event_handler.go
Outdated
| func (eh *eventHandlerImpl) handle(workflowChan <-chan watch.Event) { | ||
| log.Printf("event handler started") | ||
| for event := range workflowChan { | ||
| wf, ok := event.Object.(*v1alpha1.Workflow) |
There was a problem hiding this comment.
type checking should be done on the Start() method
Signed-off-by: Gosha <[email protected]>
Signed-off-by: Gosha <[email protected]>
Signed-off-by: Gosha <[email protected]>
Signed-off-by: Gosha <[email protected]>
Signed-off-by: Gosha <[email protected]>
Signed-off-by: Gosha <[email protected]>
|
@qadiludmer followed you comments, and eventually erased the handler. think that I will bring it back |
Signed-off-by: Gosha <[email protected]>
Signed-off-by: Gosha <[email protected]>
Signed-off-by: Gosha <[email protected]>
Signed-off-by: Gosha <[email protected]>
Signed-off-by: Gosha <[email protected]>
Signed-off-by: Gosha <[email protected]>
gosharo
added
the
DeployEnforcer/MergeOnceApproved
Signed-off-by: Gosha <[email protected]>
Signed-off-by: Gosha <[email protected]>
Signed-off-by: Gosha <[email protected]>
qadiludmer
approved these changes
Jul 8, 2023
Signed-off-by: GoshaDozoretz <[email protected]>
Signed-off-by: Gosha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gosha [email protected]
Pull Request
Description
Please provide a brief description of the changes made in this pull request.
Related Issue(s)
If this pull request addresses or relates to any open issues, please mention them here using the syntax
Fixes #<issue_number>orResolves #<issue_number>.Checklist
Before submitting this pull request, please ensure that you have completed the following tasks:
Testing Instructions
Please provide clear instructions on how to test and verify the changes made in this pull request.
Additional Information
Add any additional information or context that would be helpful in understanding and reviewing this pull request.