Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for #1203.
It seems there are 2 properties in ffmpeg called
bits_per_coded_sample
:AVCodecParameters::bits_per_coded_sample
https://ffmpeg.org/doxygen/6.0/structAVCodecParameters.html#a3866500f51fabfa90faeae894c6e955c
AVCodecContext::bits_per_coded_sample
https://ffmpeg.org/doxygen/6.0/structAVCodecContext.html#a5273a8cf73ef598d632c6eee1379d5ad
I assume we want the one from AVCodecContext, so I changed the docstring to match.
I wrote 3 tests for the QT RLE decoder:
one for a valid value,
one for a invalid value,
and one to catch the encoder setter warning.
Here are the valid values:
https://ffmpeg.org/doxygen/6.0/qtrle_8c.html