Expose bits_per_coded_sample on VideoCodecContext #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qtrle decoder needs `bits_per_coded_sample` to be set when decoding a packet.
|
Can we have a unit test which exercises the getter and setter please? |
jlaine
reviewed
Oct 30, 2023
jlaine
reviewed
Oct 30, 2023
|
In addition to jlaine's comments, this needs to be redone with the new style property attribute and it needs the type hint. |
Closed
WyattBlue
force-pushed
the
bits_per_coded_sample
branch
from
eec3ba2 to
726f136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qtrle decoder needs
bits_per_coded_sampleto be set when decoding a packet.