Server should exit with non-0 on error

[martimors]

Closes #16474 .

Just sys.exit(process.returncode) would be fine here, but for the sake of consistency with the rest of the code, I went for the exit_with_error utility. The server process is expected to run for ever until stopped, so we should never get a 0 exit code from the process, hence there is no need for a ternary condition here.

I also went ahead and removed the bare except right above - all it did was log the error and continue, and this only hides potential errors and causes issues similar to the one I faced.

In my view, this is a bugfix, but I suppose some clients could depend on the 0 exit code here in theory? I have not familiarized with your versioning process so let me know if I should bump the patch version or something as part of this.

Help needed: Looks like my test fails because the settings object is not re-created between tests, thus my monkeypatch call has no effect and my test fails (passes locally but fails in CI). Could you advise if there is a way to mess up the config temporarily without impacting downstream tests?

Checklist

• This pull request references any related issue by including "closes <link to issue>"
  • If no issue exists and your change is not a small fix, please create an issue first.
• If this pull request adds new functionality, it includes unit tests that cover the changes
• If this pull request removes docs files, it includes redirect settings in mint.json.
• If this pull request adds functions or classes, it includes helpful docstrings.

[codspeed-hq]

CodSpeed Performance Report

Merging #16476 will not alter performance

_{Comparing martimors:bugfix/exit-with-non-0-on-error (7e83899) with main (46c6164)}

Summary

✅ 3 untouched benchmarks