Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server command exits with exit code 0 even when failing due to database connectivity #16474

Open
martimors opened this issue Dec 21, 2024 · 2 comments · May be fixed by #16476
Open

Server command exits with exit code 0 even when failing due to database connectivity #16474

martimors opened this issue Dec 21, 2024 · 2 comments · May be fixed by #16476
Labels
bug Something isn't working

Comments

@martimors
Copy link

Bug summary

I noticed this when deploying via helm: The pod reaches status Completed when an exception is thrown. It should exit with non-0 such that kubernetes will restart the pod.

Version info

2024.12.19222717 (helm)

Additional context

I can potentially fix the issue myself if you'll accept a contribution

@martimors martimors added the bug Something isn't working label Dec 21, 2024
@cicdw
Copy link
Member

cicdw commented Dec 21, 2024

@martimors we'd love a contribution, either to the main prefect library or https://github.com/PrefectHQ/prefect-helm! We have some contribution docs here if that's helpful to get setup. Let us know if we can help

@martimors martimors linked a pull request Dec 22, 2024 that will close this issue
4 tasks
@martimors
Copy link
Author

@martimors we'd love a contribution, either to the main prefect library or https://github.com/PrefectHQ/prefect-helm! We have some contribution docs here if that's helpful to get setup. Let us know if we can help

I gave it a stab #16476

Let me know what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants