Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Python 3.12 #11306

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Adds support for Python 3.12 #11306

merged 8 commits into from
Jan 11, 2024

Conversation

discdiver
Copy link
Contributor

@discdiver discdiver commented Dec 3, 2023

Overview

Adds Python 3.12 support and CI test coverage. Support is noted as experimental in the install docs.

Closes #10974.

Also adds conda-flavored Python 3.11 to the test matrix, as conda support for 3.11 has been added.

pendulum

To minimize user facing impact, pendulum 2.X is installed alongside any prefect version using Python 3.11 or earlier and pendulum 3.X is installed alongside any prefect version using Python 3.12 or later.

Maintenance issue added here to track upgrading or vendoring pendulum #11619.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement, docs.

For documentation changes:

  • [n/a] This pull request includes redirect settings in netlify.toml for files that are removed or renamed

@discdiver discdiver added the enhancement An improvement of an existing feature label Dec 3, 2023
Copy link

netlify bot commented Dec 3, 2023

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 22eeaf9
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/65a0101606e1e40008d68757
😎 Deploy Preview https://deploy-preview-11306--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nanthony007
Copy link

Anything preventing this? Would like to use 3.12 heading into the new year.

@discdiver discdiver added the DONT MERGE This PR shouldn't be merged (yet) label Dec 19, 2023
@discdiver
Copy link
Contributor Author

Hi @nanthony007.
You can install with 3.12 with this branch, but there are a bunch of failing tests and work on this is likely to be picked up early in the new year.

requirements-client.txt Outdated Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
versioneer.py Show resolved Hide resolved
versioneer.py Show resolved Hide resolved
@zangell44 zangell44 marked this pull request as ready for review January 11, 2024 15:28
@zangell44 zangell44 requested review from a team as code owners January 11, 2024 15:28
async def server_process():

@contextlib.asynccontextmanager
async def start_server_process():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea for a workaround!

.github/workflows/windows-tests.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@urimandujano urimandujano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@zangell44 zangell44 removed the DONT MERGE This PR shouldn't be merged (yet) label Jan 11, 2024
@zangell44 zangell44 merged commit 67d029c into main Jan 11, 2024
61 checks passed
@zangell44 zangell44 deleted the three-12 branch January 11, 2024 17:14
@Andrew-S-Rosen
Copy link
Contributor

Andrew-S-Rosen commented Jan 11, 2024

In my own personal repos, I have noticed that Python 3.12 GitHub actions tests are much (e.g. 25%) slower than <=3.11, and I see the same here. Do y'all have any ideas why this might be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.12
5 participants