fix(#137): use nullable boolean type for the Release boolean fields #707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The changes fix an issue when Helmsman doesn't overwrite positive boolean values with negatives for Helm releases while merging multiple DSFs(#137).
What
NullBool
(inspired by NullBool tyoe from sql package)Release
bool
fields to theNullBool
typeNullBool
type is considered asboolean
type, so there are no changes from the usage perspectiveVerification
make test
+ verified manuallyExample
charts/common.yaml
charts/custom.yaml
charts/spec.yaml
Expected behavior
The
jenkins
app hasenabled
field set to false and accordingly Helmsman shouldn't install this releaseCurrent behavior
With proposed changes