Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

true values will always win when merging DSFs #137

Closed
knutjda opened this issue Dec 5, 2018 · 6 comments
Closed

true values will always win when merging DSFs #137

knutjda opened this issue Dec 5, 2018 · 6 comments
Labels
stale The issue has not been active for more than 90 days and maybe no longer applicable.

Comments

@knutjda
Copy link

knutjda commented Dec 5, 2018

When passing multiple DSFs with the -f option, the DSF with a field containing a true value will always override other values. No matter the order of DSFs.

Given the following DSFs
common.yaml:

apps:
  jenkins:
    chart: "stable/jenkins"
    version: "0.21.0"
    enabled: false 
    test: true 

override.yaml:

apps:
  jenkins:
    chart: "stable/jenkins"
    version: "0.21.0"
    enabled: true 
    test: false

When I run the following commands

helmsman -f common.yaml -f override.yaml -debug
helmsman -f override.yaml -f common.yaml -debug

Both commands will output:

Applications: 
--------------- 

	chart :  stable/jenkins
	version :  0.21.0
	test :  true
	enabled :  true

Probably related to this issue in mergo: darccio/mergo#89

Tested with Helmsman version 1.7.1.

@luisdavim
Copy link
Collaborator

I would say this is a mergo bug and there's not much we can do on our side.
But I'll take a look anyway to be sure.

@TomOperator
Copy link

For those of you who need it, @Pothulapati built a fork that solves this here.

@jamesdehart
Copy link

@luisdavim now that this issue darccio/mergo#89 is closed. Is there a way to resolve the always true bug?

Thanks mate! Love this tool.

@luisdavim
Copy link
Collaborator

I'll have a look.

@github-actions
Copy link

This issue has been marked stale due to an inactivity.

@github-actions github-actions bot added the stale The issue has not been active for more than 90 days and maybe no longer applicable. label Aug 10, 2022
prizov added a commit to prizov/helmsman that referenced this issue Aug 31, 2022
prizov added a commit to prizov/helmsman that referenced this issue Aug 31, 2022
@prizov
Copy link
Contributor

prizov commented Aug 31, 2022

I've opened this PR #707 to address this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The issue has not been active for more than 90 days and maybe no longer applicable.
Projects
None yet
Development

No branches or pull requests

5 participants