-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Challenge - Vault Template Injection #1189
New Challenge - Vault Template Injection #1189
Conversation
Thank you sir! Given we will merge #1147 tomorrow: can you rename yours to 46 please? |
ace2103
to
cc623d8
Compare
5520eb9
to
4669a57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nwolniak !
I really love your work here! Some changes to be done so we can separate this challenge further from challenge7
Looking forward to it!
src/main/java/org/owasp/wrongsecrets/challenges/kubernetes/Challenge46.java
Outdated
Show resolved
Hide resolved
src/test/java/org/owasp/wrongsecrets/challenges/kubernetes/Challenge46Test.java
Show resolved
Hide resolved
…/nwolniak/wrongsecrets into command-injection-vault-template
Hi @nwolniak, really nice challenge! |
Love your work! Hope to give it another review & testing round tomorrow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test completed! (Apologies: I had to commit and create a container which shows that your work is 👍 ).
Can you apply the last requested changes please? Happy to merge after that1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this awesome challenge! Will merge it when tests are green :) .
What kind of changes does this PR include?
Description
Vault Template Injection in k8s vault environment.
Vault secrets from path 'secret/data/secret-challenge' are injected via vault template into secret-challenge-xxx pod.
Then the secrets are rendered at vault/secrets/challenge44 path in the pod.
k8s/secret-challenge-vault-deployment.yml file I couldn't manage to push new image but I have tested local test image.
Relations
Closes #814
References
Checklist: