Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge 44&45: Vault Metadata challenge #1147

Merged
merged 34 commits into from
Jan 16, 2024
Merged

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented Dec 15, 2023

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Relations

Closes #719

References

TODOs:

  • add explanation, add reason metadata
  • update tests to reflect metadata usage
  • check if it works on k8s
  • add challenge with secret in subkey
  • add explanation/reason subkey
  • check if subkeys works on k8s

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated test

@commjoen commjoen changed the title Prework for #719 Challenge 44: Vault Metadata challenge Dec 17, 2023
@commjoen commjoen changed the title Challenge 44: Vault Metadata challenge Challenge 44&45: Vault Metadata challenge Jan 7, 2024
@commjoen commjoen marked this pull request as ready for review January 8, 2024 03:21
@commjoen commjoen requested a review from bendehaan as a code owner January 8, 2024 03:21
@commjoen commjoen merged commit 6d96e1a into master Jan 16, 2024
15 checks passed
@commjoen commjoen deleted the feature-vault-challenge branch January 16, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a secret in vault metadata instead of the actual secret
2 participants