Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] base_exception: Migration to 18.0 #3075

Merged
merged 59 commits into from
Nov 27, 2024

Conversation

xaviedoanhduy
Copy link

@xaviedoanhduy xaviedoanhduy commented Oct 15, 2024

@rvalyi rvalyi changed the title [18.0][MIG] base_exception: Migraion to 18.0 [18.0][MIG] base_exception: Migration to 18.0 Oct 15, 2024
Copy link

@nicolascol nicolascol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK (test in OCA/sale-workflow#3359)

@simahawk
Copy link
Contributor

/ocabot migration base_exception
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 24, 2024
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3075-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 24, 2024
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-3075-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-3075-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

sysadminmatmoz and others added 19 commits November 27, 2024 15:54
Currently translated at 18.8% (10 of 53 strings)

Translation: server-tools-16.0/server-tools-16.0-base_exception
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_exception/sl/
Currently translated at 16.6% (10 of 60 strings)

Translation: server-tools-16.0/server-tools-16.0-base_exception
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_exception/it/
Currently translated at 86.7% (46 of 53 strings)

Translation: server-tools-16.0/server-tools-16.0-base_exception
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_exception/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-base_exception
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_exception/
Before this change, the inverse relation from the exception to the records linked to the exception was read to determine if the rule should be added or removed from the rule detected for the current records. On large database with non blocking exceptions this lead to a performance issues since this issues a read of all the SO where the exception has been applied. With this change, we only read the information from the current records
Keeps rule information into cache to avoid to always call the ORM for static informations. This is change allows a boost into the evaluation of exception rules by avoiding useless SQL queries to retrieve rules definitions
Don't call the ORM to filter current recordset. Replace call to the orm by a call to the filtered_domain method.
Currently translated at 100.0% (54 of 54 strings)

Translation: server-tools-16.0/server-tools-16.0-base_exception
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_exception/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-base_exception
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_exception/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-17.0/server-tools-17.0-base_exception
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_exception/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-17.0/server-tools-17.0-base_exception
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_exception/
Currently translated at 100.0% (51 of 51 strings)

Translation: server-tools-17.0/server-tools-17.0-base_exception
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_exception/it/
Currently translated at 100.0% (51 of 51 strings)

Translation: server-tools-17.0/server-tools-17.0-base_exception
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_exception/es/
@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-base_exception branch from 1801f21 to 78ae389 Compare November 27, 2024 08:56
@xaviedoanhduy
Copy link
Author

hi @simahawk, can you merge it again?

@rvalyi
Copy link
Member

rvalyi commented Nov 27, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3075-by-rvalyi-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 2b522cf into OCA:18.0 Nov 27, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4aff075. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.