[MIG] sale_exception: Migration to 18.0 #3359
Open
+19,234
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasperalta1
force-pushed
the
18.0-mig-sale_exception
branch
from
2253491 to
e2092d0
Compare
|
@matiasperalta1 Thanks for this. Don't forget to point to the depending PR in this description. Moreover, you can embed that PR here following: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29 This allows to run the tests and runboat to allow functional testing. Thanks |
|
/ocabot migration sale_exception |
matiasperalta1
force-pushed
the
18.0-mig-sale_exception
branch
3 times, most recently
from
32b16c3 to
8cc6b57
Compare
|
@rousseldenis Thank you! I embed the base exception model in order to test sale exception module |
|
@matiasperalta1 Could you check tests ? |
Rule should only count available stock from selected warehouse from sale order. Without warehouse in context, it currently sums all stock available in all warehouses.
The previous parent menu has an action attached, and with these modules, it can't be clicked.
* [FIX] sale_exception confirm wizard * [FIX] add test of test_all_draft_orders & flake8 & readme.rst * [FIX] improve codecov test * [FIX] delete odl translation * [FIX] add Camptocamp to author * [FIX] readme.rst
Raise SingletonError when you have a recordset with multiple sale order. This restore the capability to write on multiple sale.order
Currently, it's located at the root menu because. It's a migration bug because the old menu was removed from 11.0.
…eptions with "is blocking" checked
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_exception Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_exception/
Currently translated at 83.7% (36 of 43 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_exception Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_exception/fr/
Currently translated at 100.0% (43 of 43 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_exception Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_exception/es/
Currently translated at 100.0% (43 of 43 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_exception Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_exception/es/
Currently translated at 100.0% (43 of 43 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_exception Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_exception/it/
Currently translated at 100.0% (43 of 43 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_exception Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_exception/sv/
Currently translated at 100.0% (43 of 43 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_exception Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_exception/it/
matiasperalta1
force-pushed
the
18.0-mig-sale_exception
branch
2 times, most recently
from
644e443 to
e536671
Compare
|
@rousseldenis The errors in the tests come from the base_exception module, could it be? |
StefanRijnhart
requested changes
Dec 2, 2024
| # together at the end even if we update the exception_ids many times. | ||
| # On previous versions, this could be unoptimized. | ||
| (self - records).exception_ids = [(3, rule.id)] | ||
| records.exception_ids = [(4, rule.id)] |
There was a problem hiding this comment.
Please use the appropriate command from fields.Command rather than literal 3, 4 etc.
matiasperalta1
force-pushed
the
18.0-mig-sale_exception
branch
3 times, most recently
from
e5d3416 to
b44e26b
Compare
matiasperalta1
force-pushed
the
18.0-mig-sale_exception
branch
from
b44e26b to
488de35
Compare
|
@rousseldenis Is it ready to merge? |
|
@matiasperalta1 Please check #3359 (comment). I see you tried replacing 4 with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.