[16.0][MOV] sale_by_packaging becomes sell_only_by_packaging #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions of this module were first added into sale_order_line_packaging_qty. After sorting out and extracting the different functions in multiple modules in the previous commits, this one gets it all together in a single module. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Following warning is shown at runtime: WARNING odoodb_test odoo.models: method product.template._check_sell_only_by_packaging_can_be_sold_packaging_ids: @constrains parameter 'packaging_ids.can_be_sold' is not a field name Only fields of the current model can be used in a constrains. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
…g SO line create/update Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
The automatic assignation of a packaging and packaging quantity was done only for product to `only_sell_by_packaging` But if possible it should also be done for other products. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
When a product must be sold by packaging do not allow for a packaging qantity at zero or negative. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
When the uom quantity of a sale order line is changed for a value that is not a multiple of possible packaging. The packaging and the packaging quantity must be reset to an empty value Signed-off-by: Carmen Bianca BAKKER <[email protected]>
This is taken from OCA@290aed9 Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
When a quantity is set on the sale order line before or at the same time than the product itself, the onchange triggered will replace the line set quantity with the default size of the package. This is especially problematic for sales order created programmatically. So to improve the solution, if the quantity fits with the package quantity it is kept. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
The test was calling the onchanges manually to test their result, but as some onchanges must be called in cascade to have a correct result, the test tells more about itself, if it calls the onchanges in the correct order or not. Using Form will test them correctly in cascade automatically. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
This feature was problematic because for order created programatically By changing the packaging on product change the quantity ordered would also change. The correct packaging will be set on save. And if not possible an error will be raised by a constraint. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Before this change the packaging was always overridden hence the user had not control on the packaging to be used on SO line. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
When the product_uom_qty is computed from inverse method of packaging qty the packaging is already there and there's no need to auto-assign. This also prevents skipping direct writes on prod uom qty or other keys other than product_packaging. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
This check is already done by core sale module. Tests where not checkingt for that specific exception. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
This change allows to be more specific on which product.packaging can be sold or not. By default the value from the product.packaging.type is used. But it is editable afterwards, with this change. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
The product_product_packaging_qty on sale.order.line should always be an integer, no ? Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
QuocDuong1306
force-pushed
the
16.0-mov-sale_by_packaging
branch
4 times, most recently
from
8bee97c to
3c2631b
Compare
jbaudoux
reviewed
Oct 24, 2023
jbaudoux
reviewed
Oct 24, 2023
QuocDuong1306
force-pushed
the
16.0-mov-sale_by_packaging
branch
from
3c2631b to
bf5a0f5
Compare
|
Hi @jbaudoux , I updated |
|
/ocabot migration sale_by_packaging |
|
@QuocDuong1306 @jbaudoux don't we need a post install hook to migrate data from the old module? |
santostelmo
suggested changes
Oct 27, 2023
| ) | ||
| def _check_product_packaging_sell_only_by_packaging(self): | ||
| for line in self: | ||
| if not line.product_id.sell_only_by_packaging: |
There was a problem hiding this comment.
Suggested change
| if not line.product_id.sell_only_by_packaging: | |
| if not line.product_id.sell_only_by_packaging or not line.product_uom_qty: |
@QuocDuong1306 IMO there's no point to check lines without any quantity assigned. If we are not able to assign 0 to the product_uom_qty we get stuck in many circumstances (specially when the order is already confirmed).
There was a problem hiding this comment.
@QuocDuong1306 Thank you for the change
QuocDuong1306
force-pushed
the
16.0-mov-sale_by_packaging
branch
from
bf5a0f5 to
f440220
Compare
santostelmo
approved these changes
Oct 30, 2023
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 354fa06. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module feature was extracted from the original sale-workflow/sale_by_packaging module.
This module supports 2 features based on sale_by_packaging v14:
Sell only by packaging: On product template model, this checkbox restricts
sales of these products if no packaging is selected on the sale order line.
If no packaging is selected, it will either be auto-assigned if the quantity
on the sale order line matches a packaging quantity or an error will be raised.
Force sale quantity (on the packaging): force rounds up the quantity during
creation/modification of the sale order line with the factor set on the packaging.
Change:
sell_only_by_packagingis now company dependentDepend on:
Base on: