[16.0] [ADD] shopinvader_product_sale_packaging #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marielejeune
commented
Oct 3, 2023
marielejeune
force-pushed
the
16.0-shopinvader_product_sale_packaging
branch
3 times, most recently
from
fffb712 to
b583dd6
Compare
marielejeune
commented
Oct 3, 2023
marielejeune
force-pushed
the
16.0-shopinvader_product_sale_packaging
branch
from
b583dd6 to
3d4cf49
Compare
marielejeune
force-pushed
the
16.0-shopinvader_product_sale_packaging
branch
2 times, most recently
from
b8abb5b to
d5ad128
Compare
marielejeune
force-pushed
the
16.0-shopinvader_product_sale_packaging
branch
4 times, most recently
from
042e8a4 to
caad935
Compare
|
@sbidoul Do you see a way to make this pipeline succeed? The company is lost from the context when calling |
|
🍏 |
|
@marielejeune all deps got merged ;) |
lmignon
reviewed
Dec 15, 2023
shopinvader_product_sale_packaging/schemas/product_packaging.py
Outdated
Show resolved
Hide resolved
With auth=none, request.env does not have a user, and therefore no company_id. Use the super user to avoid issues in other addons that expect env.company to be defined.
marielejeune
force-pushed
the
16.0-shopinvader_product_sale_packaging
branch
from
345e095 to
221a215
Compare
|
can we merge or extrapolate the fix by @sbidoul ? |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 2e20821. Thanks a lot for contributing to shopinvader. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add packaging info on products exports. Extracted from
shopinvader_sale_packagingNB: When migrating from v14 to v16 model
product.packaging.typewas renamedproduct.packaging.level