clight: init

[eadwu]

I scared myself so many times before remembering the webcam lighting up was due to the program.

Motivation for this change

Auto adjusting brightness is one fine feature (or at least in my opinion).

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

[infinisil]

Yeah something like that, nice

[infinisil]

Still some things to complain about, I hope you don't mind. Overall this PR looks very good, nice work! Feel free to ping me when you did the changes, GitHub doesn't send notifications just from pushing new commits unfortunately

Once everything is addressed, I'll do a final test to double check various combinations of options work and merge it afterwards assuming no problems

[infinisil]

And while testing this I found these changes necessary too:

diff --git a/nixos/modules/rename.nix b/nixos/modules/rename.nix
index faa2ea82181..6228c95ae91 100644
--- a/nixos/modules/rename.nix
+++ b/nixos/modules/rename.nix
@@ -258,8 +258,18 @@ with lib;
     (mkRenamedOptionModule [ "networking" "resolvconfOptions" ] [ "networking" "resolvconf" "extraOptions" ])
 
     # Redshift
-    (mkAliasOptionModule [ "services" "redshift" "latitude" ] [ "location" "latitude" ])
-    (mkAliasOptionModule [ "services" "redshift" "longitude" ] [ "location" "longitude" ])
+    (mkChangedOptionModule [ "services" "redshift" "latitude" ] [ "location" "latitude" ]
+      (config:
+        let value = getAttrFromPath [ "services" "redshift" "latitude" ] config;
+        in if value == null then
+          throw "services.redshift.latitude is set to null, you can remove this"
+          else builtins.fromJSON value))
+    (mkChangedOptionModule [ "services" "redshift" "longitude" ] [ "location" "longitude" ]
+      (config:
+        let value = getAttrFromPath [ "services" "redshift" "longitude" ] config;
+        in if value == null then
+          throw "services.redshift.longitude is set to null, you can remove this"
+          else builtins.fromJSON value))
 
   ] ++ (flip map [ "blackboxExporter" "collectdExporter" "fritzboxExporter"
                    "jsonExporter" "minioExporter" "nginxExporter" "nodeExporter"
diff --git a/nixos/modules/services/x11/redshift.nix b/nixos/modules/services/x11/redshift.nix
index e46c70e5f3b..55f8f75021b 100644
--- a/nixos/modules/services/x11/redshift.nix
+++ b/nixos/modules/services/x11/redshift.nix
@@ -89,7 +89,7 @@ in {
     systemd.user.services.redshift =
     let
       providerString = if lcfg.provider == "manual"
-        then "${lcfg.latitude}:${lcfg.longitude}"
+        then "${toString lcfg.latitude}:${toString lcfg.longitude}"
         else lcfg.provider;
     in
     {

The first one to convert from the strings services.redshift.* to the float options location.*, and the second one to have the floats be turned to strings in redshift

[eadwu]

Applied patch.

[infinisil]

Thanks for the patience :)

[turboMaCk]

is there any documentation on how this can be used? I was using provider on redshift service and have no idea how to make it compatible with this change.

[infinisil]

@turboMaCk You should only be getting a warning, no errors, so this is backwards compatible. Is that the case?

[turboMaCk]

I got error

The option services-redshify.provider defined in .... does not exist

Anyway I think I've got it working by using location.provider = "goeclue2" instead.

[infinisil]

@turboMaCk Ah thanks for the report, this was a mistake in this PR, #68852 fixes it