Why does location.provider exist?

[worldofpeace]

Describe the bug
If you set location.provider to geoclue2 it enables geoclue2.
It seems to exist only for clight.

cc @eadwu and @infinisil maybe?

[matthewbauer]

It can probably be removed if this is the only place it's used. It looks like it means "is location.latitude and location.longitude set and should it be used to determine location".

I think location.latitude and location.longitude should probably just default to null and we only set those values when it's not null.

[infinisil]

It also exists for the redshift module. This was done on my request in #64309, since both redshift and clight would have exactly the same options for location.

[jonringer]

the redshift module doesn't consume provider though, only lat/long. from what I saw, it was only there to do services.geoclue2.enable = true; see #84019

[infinisil]

@jonringer It very much does:

nixpkgs/nixos/modules/services/x11/redshift.nix

Lines 107 to 109 in f75c11c

	providerString = if lcfg.provider == "manual"
	then "${toString lcfg.latitude}:${toString lcfg.longitude}"
	else lcfg.provider;

[jonringer]

could be re-written as:

 providerString = if !services.geoclue2.enable
   then "${toString lcfg.latitude}:${toString lcfg.longitude}" 
   else "geoclue2";

[worldofpeace]

It's certainly an interesting thing, but I'm not sure any action is needed on it.