-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add GNOME #43150
doc: add GNOME #43150
Conversation
doc/languages-frameworks/gnome.xml
Outdated
<title>Icons</title> | ||
|
||
<para> | ||
When an application uses icons, an icon theme should be available in <envar>XDG_DATA_DIRS</envar>. The default <link xlink:href="https://www.freedesktop.org/wiki/Software/icon-theme/">hicolor-icon-theme</link> is recommended, unless the application needs some specific icons not available in there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently, hicolor-icon-theme
does not contain any icons. Nevertheless, we should mention it for its setup hook that removes index.theme
files.
doc/languages-frameworks/gnome.xml
Outdated
</listitem> | ||
<listitem> | ||
<para> | ||
<package>gobjectIntrospection</package> setup hook populates <envar>GI_TYPELIB_PATH</envar> variable with <filename>lib/girepository-1.0</filename> directories of dependencies, which is then added to wrapper by <package>wrapGAppsHook</package>. It also adds <filename>share</filename> directories of dependencies to <envar>XDG_DATA_DIRS</envar>, which is intended to promote GIR files but it also <link xlink:href="https://github.com/NixOS/nixpkgs/issues/32790">pollutes the closures</link> of packages using <package>wrapGAppsHook</package>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix the pollution.
Regarding GStreamer this is useful: https://gstreamer.freedesktop.org/documentation/plugins.html |
This uses wrapGAppsHook to be able to make it so that Termonad can see the GTK icons it uses. This is as described in NixOS/nixpkgs#43150. It appears that hicolor-icon-theme doesn't actually contain any icons, so instead I'm using adwaita-icon-theme.
This documentation was helpful in getting icons to actually work in a GTK app I am developing. It would be really nice to get this in the nixpkgs manual. The one problem I did run into was with Other than that, this looks good and is a 👍 from me. |
Actually, nowadays I just prefer to let users install an icon theme of their own choosing. |
What is the correct thing to do? Specify I'm guessing that adding
As a developer, I'd rather have my application work for my users even if they don't have an icon theme setup correctly. It's a really bad experience if someone runs my software and icons don't work correctly. As a developer, I definitely want to avoid that. Is there some way to set this up? For instance, I'd like to specify that my app should use the adwaita icon theme, unless the user has their own icon theme set somewhere. Do you know of a good way to do that? The edit: I just took a look at both the nixos manual and the nixpkgs manual, and it doesn't look like there is anything about GTK icon themes. It might be nice to add something about this to either the nixos or nixpkgs manual, depending on how it should work. |
Unfortunately, there is no other way – you either include an icon theme in the package’s closure, or you might not have icons on insufficiently configured systems. (Side note: It would be nice to have a mechanism for specifying system dependencies but we are not there yet.) In my opinion, if you do not use DE, you are expected to create it yourself.
should be enough. I really need to write a chapter on creating a baseline freedesktop system though, as many NixOS users run some kind of bare-bones WM. |
Yeah, this would be really nice. I run XMonad, but not configured from |
What about people e.g. using |
They can still install the icon theme, either with nix or their native package manager.
Well, the main issue with depending on |
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/request-for-help-packaging-gnome-extensions/2366/2 |
958c46c
to
e94e731
Compare
Don't fret, just resolved the conflict and added a little commit separately. |
Perhaps we should remove it from stdenv, and just keep it in GNOME sub-chapter. I'd like those setup hooks to be documented in the locality of the GNOME sub-chapter. |
@jtojnar That's perfect 👍 |
0aa3f23
to
6275823
Compare
Closes: NixOS#16285
Examples are updated to commits that use them as well.
Backported in 9d8e161 |
Work in progress documentation on packaging GNOME ecosystem applications. Comments and questions welcome.
Closes: #16285