-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pulseeffects: fix functionality for non-GNOME environments #53857
Conversation
This fixes missing icons on non-GNOME environments.
DConf GSettings module requires a DConf service. In my experience, this is achieved by adding |
c799004
to
915f374
Compare
First of all thanks a lot for your fast feedback! You're right I guess. I removed the |
I am discussing the icons here: #43150 (comment) |
so let's discuss the issue there and merge or close this PR depending on the result? |
Is this PR still relevant? |
I guess not, if the addition can be that simple :) |
Motivation for this change
Until now
pkgs.pulseeffects
only worked on GNOME-like environments and didn't work in different desktop environments (in my casei3wm
as window manager and a simple X session init script).Icons now work and settings can be persisted.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)