Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/check-shell: only run if shell.nix or ./ci/** is changed #360249

Merged
merged 1 commit into from
Nov 29, 2024
Merged

ci/check-shell: only run if shell.nix or ./ci/** is changed #360249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/check-shell.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: "Check shell"

on:
pull_request_target:
paths:
- 'shell.nix'
- './ci/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- './ci/**'
- 'ci/**'

All examples here do not include ./
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

Copy link
Member

@infinisil infinisil Nov 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it works, I don't think we should care about such nits :)

Copy link
Contributor

@azuwis azuwis Nov 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./ci/** does not work in practice.

I opened 2 PRs in my own nixpkgs fork.

  1. Edit shell.nix: shell.nix: edit to trigger CI azuwis/nixpkgs#1

  2. Edit ci/default.nix ci/default.nix: edit to trigger CI azuwis/nixpkgs#2

You can see in https://github.com/azuwis/nixpkgs/actions/workflows/check-shell.yml that only azuwis#1 trigger the check-shell workflow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#360283

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh damn, good catch, I wouldn't have expected that!


permissions: {}

Expand Down