-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/check-shell: only run if shell.nix
or ./ci/**
is changed
#360249
Conversation
saves a bit of CI time
@@ -2,6 +2,9 @@ name: "Check shell" | |||
|
|||
on: | |||
pull_request_target: | |||
paths: | |||
- 'shell.nix' | |||
- './ci/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- './ci/**' | |
- 'ci/**' |
All examples here do not include ./
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it works, I don't think we should care about such nits :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./ci/**
does not work in practice.
I opened 2 PRs in my own nixpkgs fork.
-
Edit
shell.nix
: shell.nix: edit to trigger CI azuwis/nixpkgs#1 -
Edit
ci/default.nix
ci/default.nix: edit to trigger CI azuwis/nixpkgs#2
You can see in https://github.com/azuwis/nixpkgs/actions/workflows/check-shell.yml that only azuwis#1 trigger the check-shell
workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh damn, good catch, I wouldn't have expected that!
saves a bit of CI time
check triggered: Mic92#41
check skipped: Mic92#42
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.