rust: support structuredAttrs in setup hooks #340862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to test rust-analyzer with structuredAttrs turned on once the cargo setup hooks support it.
wolfgangwalther
requested review from
zowoq,
winterqt and
figsoda
as code owners
Tested the following packages with and without structuredAttrs: - rust-analyzer: cargo-build-hook, cargo-check-hook - jujutsu: cargo-nextest-hook - kornia-rs: maturin-build-hook
wolfgangwalther
force-pushed
the
structured-attrs-setup-hooks-rust
branch
from
7b9f6ca to
d5013e9
Compare
emilazy
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Thank you so much 🥲 When doing #339702, before I fixed the SSH signing tests, I had a terribly hard time trying to figure out how to get it to pass cargo nextest run --filterset "not 'test(#test_ssh_signing::*)'" and eventually gave up and changed the syntax to !test(test_ssh_signing::).
philiptaron
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Looks great and runs great as always, @wolfgangwalther. Thanks for your contributions.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Follow up to #318614 to support structuredAttrs in
rust's setup hooks. The changes in those hooks are a bit bigger, so I split them into a separate PR.Same as before: For each hook, I built a package (mentioned in the commit message) with and without structuredAttrs turned on. Those would fail with structuredAttrs on master, but succeed with structuredAttrs after this PR.
CC @emilazy @philiptaron @tie
Since the changed setup hooks won't trigger ofborg to mention the maintainers: @NixOS/rust
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.