jujutsu: refactor, add emily to maintainers #339702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not seem to be required any more.
Yeah, you can add me as a maintainer too. :) |
ofborg
bot
added
11.by: package-maintainer
misuzu
reviewed
Sep 5, 2024
pkgs/by-name/ju/jujutsu/package.nix
Outdated
| libgit2 | ||
| libssh2 | ||
| ] | ||
| ++ lib.optional (!stdenv.hostPlatform.isDarwin) [ openssl ] |
There was a problem hiding this comment.
Suggested change
| ++ lib.optional (!stdenv.hostPlatform.isDarwin) [ openssl ] | |
| ++ lib.optional (!stdenv.hostPlatform.isDarwin) openssl |
Suggested change
| ++ lib.optional (!stdenv.hostPlatform.isDarwin) [ openssl ] | |
| ++ lib.optionals (!stdenv.hostPlatform.isDarwin) [ openssl ] |
There was a problem hiding this comment.
Thanks, typo 🫠 Fixed!
We need to lint for this…
The test executables are no longer installed by default, but this still picks up one of the build tools. Additionally, move the derivation attribute according to convention.
emilazy
force-pushed
the
push-olnrxsxluqwv
branch
from
2c5f0d1 to
e2cf429
Compare
|
Result of 2 packages built:
|
samueltardieu
approved these changes
Sep 5, 2024
Indeed! |
thoughtpolice
approved these changes
Sep 5, 2024
|
I have plenty of bones to pick with the style, but it’ll get swept up in the treewide before 24.11 anyway, so might as well bite the bullet now :) (I think the “new files must be formatted” CI lint would complain if I hadn’t done it, anyway, given the |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is critical to my workflow, so let’s step up to help out.
Probably these commits didn’t have to be so thoroughly factored out, but when Jujutsu makes it this easy, why not?
cc @bbigras – did you want to co‐maintain this?
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.