Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs: darwin: use architecture-native SDK #274287

Closed
wants to merge 1 commit into from
Closed

emacs: darwin: use architecture-native SDK #274287

wants to merge 1 commit into from

Conversation

tnytown
Copy link
Contributor

@tnytown tnytown commented Dec 14, 2023

Description of changes

#253892 bumped the Emacs derivations to apple_sdk_11_0 for headers required by the Mac port on Apple Silicon Macs. That change caused many issues on older macOS versions. This change switches back to the platform-native SDK (10.12 on x86_64-darwin and 11.0 on aarch64-darwin) and gates the newly required headers by architecture.

CC @quentinmit and @knl. I tested emacs-macport for x86_64-darwin and the problematic aligned_alloc isn't being imported anymore, but I would appreciate confirmation from your end.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tnytown tnytown requested a review from adisbladis as a code owner December 14, 2023 19:48
@github-actions github-actions bot added the 6.topic: emacs Text editor label Dec 14, 2023
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 14, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 14, 2023
@Atemu Atemu requested a review from reckenrode December 15, 2023 16:52
@tnytown tnytown closed this by deleting the head repository Apr 30, 2024
@AndersonTorres
Copy link
Member

??

@tnytown
Copy link
Contributor Author

tnytown commented May 1, 2024

Ouch, did this by accident while cleaning up my GitHub forks. @AndersonTorres would you be interested in this change if I re-submit it? I hadn't realized that it's been stalled all this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: emacs Text editor 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants