emacs: use llvmPackages_14 from apple_sdk_11_0

[tnytown]

Description of changes

Explicitly pull in llvmPackages_14 from apple_sdk_11_0 for Emacs. This should pull in the correct Libsystem headers and resolve the remaining compilation issues related to the new SDK.

Tested:

• emacs28-macport.withPackages
  • Under a nix repl (nix repl --expr 'import ./.{system="x86_64-darwin";}'), evaluate :b emacs28-macport.pkgs.withPackages (epkgs: with epkgs.melpaStablePackages; [ magit ])
  • result/bin/emacs -nw --batch --eval '(print (progn (package-initialize) (magit-version)))' yields "3.3.0", indicating that Magit has been correctly installed
• emacs28-macport
  • Builds correctly under Rosetta x86_64, result/Applications/Emacs.app contains an Info.plist
  • App bundle opens correctly

I've only tested this under Rosetta on an ARM Mac, so I'd appreciate any testing from those on Intel Macs.

Resolves #253502.

CC @sixtysecrun, @knl, @AndersonTorres

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[alienman5k]

Is there any plan to merge this to NixOS:23.05 as this is also failing in stable branch?

[AndersonTorres]

I could possibly try, however I don't have Darwin.

[tnytown]

Is there any plan to merge this to NixOS:23.05 as this is also failing in stable branch?

I believe the regression shouldn't be present on 23.05, as #252244 hasn't been backported. If you're referring to the build issues with Apple Silicon, the x86_64-darwin derivations on stable should work under Rosetta.

[quentinmit]

I believe this commit broke emacs on macOS 10.14. The resulting binaries fail with

dyld: Symbol not found: _aligned_alloc
  Referenced from: /nix/store/n6wnda0r2bi5wr0pr16rgd46l8pmgvvi-emacs-nox-28.2/bin/emacs
  Expected in: /usr/lib/libSystem.B.dylib

I presume because they are now linking with a newer SDK that has the aligned_alloc symbol. See upstream bug: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36172 and macports bug: https://trac.macports.org/ticket/61406

I was able to fix it with this overlay:

  emacs-nox = let
    inherit (final) lib stdenv;
  in prev.emacs-nox.overrideAttrs (old: {
    configureFlags = old.configureFlags ++ lib.optionals stdenv.isDarwin [
      "ac_cv_func_aligned_alloc=no"
      "ac_cv_have_decl_aligned_alloc=no"
      "ac_cv_func_posix_spawn_file_actions_addchdir_np=no"
    ];
  });

[tnytown]

@quentinmit that's odd -- is it this specific commit that broke emacs-nox on 10.14 or could it have been earlier related commits (bdce9a2, f607a78)?

i believe this change should have only affected the emacs-macport variant, as llvmPackages_14 is only used there:

nixpkgs/pkgs/applications/editors/emacs/make-emacs.nix

Lines 138 to 140 in 6be6220

	inherit (if variant == "macport"
	then llvmPackages_14.stdenv
	else stdenv) mkDerivation;

sorry for the breakage!

[quentinmit]

@quentinmit that's odd -- is it this specific commit that broke emacs-nox on 10.14 or could it have been earlier related commits (bdce9a2, f607a78)?

i believe this change should have only affected the emacs-macport variant, as llvmPackages_14 is only used there:

nixpkgs/pkgs/applications/editors/emacs/make-emacs.nix

Lines 138 to 140 in 6be6220

	inherit (if variant == "macport"
	then llvmPackages_14.stdenv
	else stdenv) mkDerivation;

sorry for the breakage!

It certainly could have been one of the earlier commits you listed; I assumed it was this one just based on the commit message about switching to a newer SDK. No worries!

[knl]

I'm seeing the same problem on 10.14 with emacs-macport:

❯ emacs --version
dyld: lazy symbol binding failed: Symbol not found: _aligned_alloc
  Referenced from: /nix/store/4x0dxbc13m9q68pphx9lwl61n0h97m9p-emacs-mac-macport-29.1/bin/emacs
  Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: _aligned_alloc
  Referenced from: /nix/store/4x0dxbc13m9q68pphx9lwl61n0h97m9p-emacs-mac-macport-29.1/bin/emacs
  Expected in: /usr/lib/libSystem.B.dylib

[tnytown]

We might be able to fix this by removing the SDK hacks. It seems like the newly required libraries are gated on the 11.0 SDKs.