gnome.nixos-gsettings-overrides: Ensure the settings are not overwritten #197051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOS@1d4bdda started copying override files from packages into the schema for compilation. `gsettings-desktop-schemas` package contains `remove-backgrounds.gschema.override` which is later in the alphabet than `nixos-defaults.gschema.override` so it would take precedence over the values from the GNOME NixOS module, causing the background to not be set, among other things. Let’s rename the override file coming from the module to be applied last.
github-actions
bot
added
the
6.topic: GNOME
ofborg
bot
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
1d4bdda started copying override files from packages into the schema for compilation.
gsettings-desktop-schemaspackage containsremove-backgrounds.gschema.overridewhich is later in the alphabet thannixos-defaults.gschema.overrideso it would take precedence over the values from the GNOME NixOS module, causing the background to not be set, among other things.Let’s rename the override file coming from the module to be applied last.
Noticed in #197029
Things done