webp-pixbuf-loader: Adopt by GNOME #197029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: GNOME
ofborg
bot
requested review from
cwyc,
hedning,
bobby285271,
dasj19 and
amaxine
ofborg
bot
added
11.by: package-maintainer
GNOME uses this for backgrounds so let’s add GNOME team to maintainers and adopt GNOME coding style aimed at cleaner git diffs: - Format with `nixpkgs-fmt` - Inherit `moduleDir` variable since it has the same name - Avoid re-using `pname` for `src` in case it is overwritten - Use conventional attribute ordering - Have one dependency per line in inputs - Move comments closer to what they describe - Wrap long substitute line - Quote bash values
Note that no other GNOME apps currently support WebP on NixOS because we lack a usable composition method for gdk-pixbuf caches.
github-actions
bot
added
6.topic: nixos
jtojnar
force-pushed
the
webp-loader
branch
2 times, most recently
from
1386eca to
fe754d3
Compare
Unlike previously, we now fail loudly when a package not containing a gdk-pixbuf modules is passed.
A hack until gdk-pixbuf learns to support multiple cache files.
A hack until gdk-pixbuf learns to support multiple cache files.
A hack until gdk-pixbuf learns to support multiple cache files.
A hack until gdk-pixbuf learns to support multiple cache files.
This was referenced Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
GNOME uses this for backgrounds so let’s add GNOME team to maintainers and adopt GNOME coding style aimed at cleaner git diffs.
Also add into GNOME packages so that gnome-backgrounds 43 work.
Fixes: #196428
Things done
./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes