Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: bootstrap-tools: disable iconv for the hello test #158530

Closed
wants to merge 2 commits into from
Closed

revert: bootstrap-tools: disable iconv for the hello test #158530

wants to merge 2 commits into from

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 8, 2022

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Feb 8, 2022
@zowoq zowoq changed the title Ffs revert: bootstrap-tools: disable iconv for the hello test Feb 8, 2022
@zowoq zowoq marked this pull request as draft February 8, 2022 00:27
@zowoq zowoq mentioned this pull request Feb 8, 2022
Merged
13 tasks
@siraben
Copy link
Member

siraben commented Feb 8, 2022

Result of nixpkgs-review pr 158530 run on aarch64-darwin 1

1 package built:
  • hello

@ofborg ofborg bot requested a review from edolstra February 8, 2022 00:40
@siraben
Copy link
Member

siraben commented Feb 8, 2022 •
edited
Loading

nix-build pkgs/stdenv/darwin/make-bootstrap-tools.nix -A test fails on aarch64-darwin with http://ix.io/3OZo

$ nix log /nix/store/7hqwvbck1bkki936gfinnq3vza93hp0f-unpack.drv | ix
http://ix.io/3OZo

@zowoq
Copy link
Contributor Author

zowoq commented Feb 8, 2022

Thanks.

@zowoq zowoq closed this Feb 8, 2022
@zowoq zowoq deleted the ffs branch February 10, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zowoq @siraben