bootstrap-tools: disable iconv for the hello test
#158517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
approved these changes
Feb 7, 2022
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
|
@NixOS/darwin-maintainers, is anyone available to test on aarch64-darwin? |
|
Result of 1 package built:
|
|
@siraben Running |
|
You merged a broken commit. On |
|
The command posted above gave me: |
|
@zowoq ah, wasn't aware. Apologies for the premature merge! |
Large parts of nixpkgs aren't tested by |
Surprising! Did it build before? |
|
Could someone on aarch64-darwin please test #158530 and confirm that it does actually build? |
|
Looks like it failed with the same error anyway: #158530 (comment)
I won't bother merging the revert for now but I'll check the @jonringer @vcunat Can we merge |
|
Strangely enough, the test job is included for x86_64-darwin: nixpkgs/pkgs/top-level/release.nix Line 184 in 60c52a7 but not for aarch64-darwin nixpkgs/pkgs/top-level/release.nix Lines 194 to 195 in 60c52a7 It could be because it still uses cross compilation: nixpkgs/pkgs/top-level/release.nix Line 192 in 60c52a7 (notice how https://hydra.nixos.org/eval/1742780?filter=stdenvBootstrapTools&compare=1742696&full= is built on x86_64-darwin) |
|
I'm sure @thefloweringash knows what TODO is left here |
Merged
|
There is: https://hydra.nixos.org/job/nixpkgs/nixpkgs-unstable-aarch64-darwin I agree it's easy to miss. For example once I forgot about it when comparing regressions from Keeping the platform in a separate jobset (for now) was a decision of the infra team. Based on experience so far (e.g. the |
|
Also, I accidentally noticed this package regressing from hello update: https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.spike.x86_64-linux |
IIRC, when this was added there were few (or no?) aarch64-darwin builders on hydra, and the support for the platform in nixpkgs was still young. I don't think there's any technical reason that aarch64-darwin needs to be special, it's more a question of if aarch64-darwin on hydra and nixpkgs is considered mature enough to be self hosting. |
|
From the hydra.nixos.org point of view, aarch64-darwin seems maybe even better supported than x86_64-darwin, and in future it's unlikely to shift the other way anymore. One issue is that it's apparently difficult to get reasonable Apple x86 HW (in terms of cost- and power- efficiency). Even to the point of using M1 emulation for x86, though some builds do have issues with that. I'm avoiding darwin stuff; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes