Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-idempotent comments in attribute parameters #219

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Jul 11, 2024

Fixes #218


This work is sponsored by Antithesis

@infinisil infinisil requested a review from piegamesde July 11, 2024 21:44
Copy link

github-actions bot commented Jul 11, 2024

Nixpkgs diff

@infinisil infinisil force-pushed the fix-idempotency-attribute-par-comments branch from 4f56429 to 6cb8544 Compare July 11, 2024 21:45
@infinisil infinisil mentioned this pull request Jul 11, 2024
2 tasks
@infinisil infinisil merged commit 278b7ee into master Jul 12, 2024
2 checks passed
@infinisil infinisil deleted the fix-idempotency-attribute-par-comments branch July 12, 2024 18:14
infinisil added a commit to tweag/nixpkgs that referenced this pull request Jul 12, 2024
infinisil added a commit to tweag/nixpkgs that referenced this pull request Jul 16, 2024
dasJ pushed a commit to NixOS/nixpkgs that referenced this pull request Jul 17, 2024
* Fix the update script so it points at the new nixos/nixfmt repo and bump to the lasest version on master.

(cherry picked from commit 2c2f1d0)

* nixfmt: unstable-2024-05-28 -> unstable-2024-07-03

(cherry picked from commit 72ae7e0)

* nixfmt-rfc-style: unstable-2024-07-03 -> unstable-2024-07-12

Notably includes NixOS/nixfmt#219
and NixOS/nixfmt#220

(cherry picked from commit 8058a2a)

---------

Co-authored-by: Daniel Baker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Idempotency bug for comments in attribute parameters
2 participants