Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idempotency bug for comments in attribute parameters #218

Closed
infinisil opened this issue Jul 11, 2024 · 0 comments · Fixed by #219
Closed

Idempotency bug for comments in attribute parameters #218

infinisil opened this issue Jul 11, 2024 · 0 comments · Fixed by #219
Labels
bug Something isn't working

Comments

@infinisil
Copy link
Member

infinisil commented Jul 11, 2024 •
edited
Loading

Input:

{ 
  foo
# bar
, baz # qux
}:
null

After one formatting:

{
  foo
  # bar
  ,
  baz, # qux
}:
null

After another:

{
  foo,
  # bar
  baz, # qux
}:
null

Note that #217 is needed to not have infinite recursion when using --verify with this.

Ping @piegamesde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Nix formatting
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix non-idempotent comments in attribute parameters NixOS/nixfmt
1 participant
@infinisil