Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite recursion when walking Abstractions #217

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Jul 11, 2024

This caused an infinite recursion when trying to minimise the non-idempotency when running --verify on

{
  foo
# bar
, baz # qux
}:
null

This work is sponsored by Antithesis

@infinisil infinisil requested a review from piegamesde July 11, 2024 21:16
Copy link

github-actions bot commented Jul 11, 2024

Nixpkgs diff

Copy link
Member

@piegamesde piegamesde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the commit message more clear that this is about the walkSubprogram, because it is only used for debugging regressions and does not affect program execution otherwise

src/Nixfmt/Types.hs Outdated Show resolved Hide resolved
@infinisil infinisil force-pushed the fix-infinite-verify-recursion branch from e838fd5 to 4aaab56 Compare July 12, 2024 18:13
@infinisil infinisil reopened this Jul 18, 2024
This caused an infinite recursion when trying to minimise the
non-idempotency when running --verify on

    {
      foo
    # bar
    , baz # qux
    }:
    null
@infinisil infinisil force-pushed the fix-infinite-verify-recursion branch from 4aaab56 to baa4bb7 Compare July 18, 2024 14:02
@infinisil infinisil merged commit e819b2d into master Jul 18, 2024
2 checks passed
@infinisil infinisil deleted the fix-infinite-verify-recursion branch July 18, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants