Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amount Display Style Option in Custom Currency #663

Merged
merged 10 commits into from
Aug 24, 2023
Merged

Amount Display Style Option in Custom Currency #663

merged 10 commits into from
Aug 24, 2023

Conversation

nlogozzo
Copy link
Member

@nlogozzo nlogozzo commented Aug 23, 2023 •
edited
Loading

Closes #644

image

@nlogozzo nlogozzo marked this pull request as ready for review August 23, 2023 22:36
@nlogozzo nlogozzo requested a review from fsobolev August 23, 2023 22:36
@fsobolev
Copy link
Member

n $ looks okay, but I think it can be improved. We could update ComboRow's model on changing currency symbol and use it, showing "100 🪙" for example.

@nlogozzo
Copy link
Member Author

n $ looks okay, but I think it can be improved. We could update ComboRow's model on changing currency symbol and use it, showing "100 🪙" for example.

That would work... world you like to tackle it or want me?

@fsobolev
Copy link
Member

That would work... world you like to tackle it or want me?

I'm going to be busy for a while so I guess you will make it faster.

@nlogozzo
Copy link
Member Author

image
image

@nlogozzo nlogozzo requested a review from fsobolev August 24, 2023 03:42
@nlogozzo nlogozzo merged commit 5cdafee into main Aug 24, 2023
@nlogozzo nlogozzo deleted the space branch August 24, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsobolev fsobolev fsobolev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to have a space between the symbol and amount
2 participants
@nlogozzo @fsobolev