-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to have a space between the symbol and amount #644
Comments
I think we'll go with this instead. |
@nlogozzo The problem is different cultures specify different formats for displaying amount with currency symbol (see CurrencyPositivePattern CurrencyNegativePattern), and I think enforcing |
I was just thinking of adding a switch to custom currency "show space between symbol and amount", but I think it's best to just look at |
On further discussion, we will implement a way to change this in custom currency |
Kind of...we were thinking of just having |
@JoseBritto would you like to take a shot at implementing it? |
I was gonna ask you, but this being due for the next release, I think I'm gonna pass. Maybe can I have a shot at implementing the currency conversion tool? I assume that gonna need to integrate with some api as well. |
Ok no worries :) Yeah i'm going to get it done now, so I can release an RC1 tonight and stable for Friday.
Yes feel free to tackle it! I'd like to get it into a release next month but being a big feature I'm ok with it taking some time. And yes it will need some API to pull conversion data from...I don't have any specific one in mind so feel free to choose what you think it best. If you have any questions, you know how to reach me :) |
Ok thanks :) |
https://github.com/NickvisionApps/Denaro/releases/tag/2023.8.1-rc1 should be on flathub beta soon...whenever gnome gitlab is up again |
I got the new update from Flathub. When trying to actually use the new setting, Denaro irrecoverably freezes. |
Could you run the app via terminal |
|
I mean those gtk-critical messages can be ignored...was the format correctly displayed when you reopened the account? If so, how many transactions do you have in the account? |
This issue occurs even when creating a brand new account. Like, if you select the option to use a custom currency during the account creation process, it's an issue. |
idk how we didn't see this as I swear it was working no problem in tested...anyway fixed with f4a705d |
When using a 3 character currency "symbols" (just letters), Denaro doesn't put a space in-between this symbol and the amount. So, for example, you would see USD1 rather than the correct USD 1. For this reason, Denaro should allow 4 characters as a symbol, or add an option to have a space between the symbol and amount.
The text was updated successfully, but these errors were encountered: