Problematic JAVA_HOME while building lang/newlisp on macOS

[LdBeth]

while run sudo bmake install on lang/newlisp, I get this error:

=> Bootstrap dependency digest>=20010302: found digest-20160304
=> Checksum SHA1 OK for newlisp-10.6.0.tgz
=> Checksum RMD160 OK for newlisp-10.6.0.tgz
=> Checksum SHA512 OK for newlisp-10.6.0.tgz
===> Installing dependencies for newlisp-10.6.0
==========================================================================
The following variables will affect the build process of this package,
newlisp-10.6.0.  Their current value is shown below:

        * CURSES_DEFAULT = curses
        * PKG_JVM_DEFAULT (defined)
        * READLINE_DEFAULT = editline

Based on these variables, the following variables have been set:

        * CURSES_TYPE = curses
        * JAVA_BINPREFIX = /opt/pkg/bin/oracle8
        * PKG_JAVA_HOME = /Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home
        * PKG_JVM = oracle-jdk8
        * READLINE_TYPE = editline
        * TERMCAP_TYPE = curses

You may want to abort the process now with CTRL-C and change their value
before continuing.  Be sure to run `/opt/pkg/bin/bmake clean' after
the changes.
==========================================================================
=> Tool dependency nbpatch-[0-9]*: found nbpatch-20151107
=> Build dependency cwrappers>=20150314: found cwrappers-20170611
=> Full dependency editline>=3.0.20130712nb1: found editline-3.1.20150325
===> Overriding tools for newlisp-10.6.0
===> Extracting for newlisp-10.6.0
===> Patching for newlisp-10.6.0
=> Applying pkgsrc patches for newlisp-10.6.0
===> Creating toolchain wrappers for newlisp-10.6.0
===> Configuring for newlisp-10.6.0
=> Substituting "java" in guiserver/guiserver.lsp
=> Fix shebang
INFO: [subst.mk:interpreter] Nothing changed in ./guiserver/scroll-pane-demo.lsp.
INFO: [subst.mk:interpreter] Nothing changed in ./guiserver/uppercase.lsp.
INFO: [subst.mk:interpreter] Nothing changed in ./guiserver/word-count.lsp.
env: Plug-Ins/JavaAppletPlugin.plugin/Contents/Home: No such file or directory
*** Error code 127

Stop.
bmake[1]: stopped in /Users/ldbeth/.pkgsrc/lang/newlisp
*** Error code 1

Stop.
bmake: stopped in /Users/ldbeth/.pkgsrc/lang/newlisp

Building outside the wrapper works fine.

I guess the JAVA_HOME /Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home contains a unescaped space and cause env through an error.

The output of MAKE_ENV contains

USETOOLS=no CLASSPATH=. JAVA_HOME=/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home CC=clang CFLAGS=-pipe\ -O3 CPPFLAGS= CXX=clang++ CXXFLAGS=-pipe\ -O3 COMPILER_RPATH_FLAG=-L F77=f77 FC=f77 FFLAGS=-O LANG=C LC_ALL=C LC_COLLATE=C LC_CTYPE=C LC_MESSAGES=C LC_MONETARY=C LC_NUMERIC=C LC_TIME=C LDFLAGS= LINKER_RPATH_FLAG=-L
PATH=/Users/ldbeth/.pkgsrc/lang/newlisp/work/.cwrapper/bin:/Users/ldbeth/.pkgsrc/lang/newlisp/work/.buildlink/bin:/Users/ldbeth/.pkgsrc/lang/newlisp/work/.tools/bin:Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin:/Library/Internet:/opt/pkg/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/pkg/sbin:/opt/pkg/bin:/opt/X11/bin:/opt/pkg/bin:/opt/pkg/bin
...

which confirms my hypnosis.

I hope there are some temporary quick fix but I don't know how to override the PATH in the wrapper.

[msk]

edb6aa5 should fix this.

[krytarowski]

@LdBeth can we close this issue?

[LdBeth]

sure