Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AERIE-2153] Remove refreshActivityValidations event trigger #370

Merged

Conversation

pcrosemurgy
Copy link
Contributor

@pcrosemurgy pcrosemurgy commented Oct 11, 2022

  • Tickets addressed: AERIE-2153 (partially)
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

Functionally reverts #330. Removes the refreshActivityValidations event trigger as an interim solution while batching of activity validations (or another solution) is worked out.

Verification

  • This is a fairly straightforward removal of functionality with no dependent tests.
  • The UI (aerie-ui) has yet to make use of activity_directive_validations so this is safe to remove.

Documentation

None.

Future work

Batching of activity validations (or another solution).

@pcrosemurgy pcrosemurgy requested a review from a team as a code owner October 11, 2022 20:58
@pcrosemurgy pcrosemurgy temporarily deployed to e2e-test October 11, 2022 20:58 Inactive
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved due to detection of the following labels: hotfix

@pcrosemurgy pcrosemurgy merged commit ca18b26 into develop Oct 11, 2022
@pcrosemurgy pcrosemurgy deleted the fix/aerie-2153-disable-activity-validation-trigger branch October 11, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants