Add Bindings Tests for Java Endpoints #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mythicaeda
added
the
test
skovati
approved these changes
Aug 8, 2023
merlin-server/src/test/java/gov/nasa/jpl/aerie/merlin/server/http/MerlinBindingsTest.java
Outdated
Show resolved
Hide resolved
Mythicaeda
force-pushed
the
add-java-bindings-tests
branch
from
5baaadb to
63749f6
Compare
…hMissionModelException` `LocalMissionModelService.refreshResourceTypes()` needs to throw the `NoSuchMissionModelException` so it can be caught by the action binding, rather than converting it to a `RuntimeException`
- Remove StubConstraintService, which was only used in that file
- Add optional header parameter to some requests
Mythicaeda
force-pushed
the
add-java-bindings-tests
branch
from
63749f6 to
e47e35c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commits (1) and (2) fix errors in our endpoint errors found while developing these tests.
Commit (3) removes an endpoint that should've been removed during #370. It was meant to be part of a Hasura Event that auto-updated activity validations when the arguments were updated, but was removed due to performance issues.
Commits (4) through (6) replace the stub Java version of MerlinBindingsTest with proper E2E tests.
Verification
See Description
Documentation
No docs need to be updated
Future work
One error that was not fixed was the
ConstraintDSLTypescriptendpoint failing to return a failure status whenplan_idis invalid. This occurs because thePostgresPlanRepository's implementation ofgetExternalResourceSchemasdoesn't check ifplanIdexists and quietly returns an empty list if it doesn't exist.