-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add External Source (and External Event) Attribute Validation #1606
Open
pranav-super
wants to merge
21
commits into
develop
Choose a base branch
from
feature/external-source-event-attributes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restricted so only admins can insert. everyone else must use the gateway.
error messages *could* be fleshed out further
error messages *could* be fleshed out further
pranav-super
temporarily deployed
to
e2e-test
November 18, 2024 20:44 — with
GitHub Actions
Inactive
pranav-super
had a problem deploying
to
e2e-test
November 18, 2024 20:44 — with
GitHub Actions
Failure
pranav-super
temporarily deployed
to
e2e-test
November 18, 2024 20:44 — with
GitHub Actions
Inactive
pranav-super
had a problem deploying
to
e2e-test
November 27, 2024 16:40 — with
GitHub Actions
Failure
pranav-super
temporarily deployed
to
e2e-test
November 27, 2024 16:40 — with
GitHub Actions
Inactive
pranav-super
temporarily deployed
to
e2e-test
November 27, 2024 16:40 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the feature of external source and event attribute validation. External sources, when uploaded, now bear attributes that describe information about them beyond the basic key, duration, or other standard fields. More miscellaneous, type-specific data, like a source's
originator
,author
, orsequence_number
(these are arbitrary examples), or something similar for events, can now be specified. This now means that source's take the following, general format:To constrain these fields, we also introduce attribute schemas for source and event types. Users can submit these when explicitly creating a source or event type here:
The general format for these attribute schemas follows that of a standard JSON Schema. For example, an attribute schema for an event type may look as follows:
This states that
EventTypeA
requires (and exclusively allows only) a single field, calledseries
, which is anobject
with subfieldstype
(astring
),make
(astring
), anditeration
(anumber
).NOTE: under deliberation is whether a stricter 'metaschema' should be imposed on top of these attributes to better constrain them, beyond simply checking that they are valid JSON Schema. While leaving out such a metaschema more aptly uses the full functionality of JSON Schema, the lack of a metaschema could allow extra junk fields, or the exclusion of fields, like
properties
.Verification
These changes were validated with an updated set of gateway tests in
e2e-tests
.Documentation
The main documentation that would change is that around the creation of source types, event types, and derivation groups.
Future work
With regards to the schema functionality specifically, the only additional feature that may need to be built and discussed further as an add-on to this is a way to constrain which event types are allowable for a given source type. The need for this and how it should be implemented, namely in the frontend, have yet to be discussed.