-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add External Source (and External Event) Attribute Validation #1560
Open
pranav-super
wants to merge
42
commits into
develop
Choose a base branch
from
feature/external-source-event-schema
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav-super
had a problem deploying
to
test-workflow
November 18, 2024 20:55 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
November 19, 2024 14:27 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
November 19, 2024 20:41 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
November 19, 2024 20:44 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
November 19, 2024 20:44 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
November 19, 2024 20:57 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
November 19, 2024 21:01 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
November 19, 2024 21:02 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
November 26, 2024 21:43 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
November 27, 2024 15:55 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
November 27, 2024 16:18 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
November 27, 2024 16:38 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
December 3, 2024 16:31 — with
GitHub Actions
Failure
Having some issues with the E2E tests, but all External Source tests are passing locally. Note that because there is a separate Gateway branch for this pull-request there's issues with running the Gateway branch locally causing model upload, I worked around this by forcing it to use a pre-uploaded model to confirm that the actual tests still pass. |
JosephVolosin
had a problem deploying
to
test-workflow
December 3, 2024 18:04 — with
GitHub Actions
Failure
…instead of CSSGridGutters
JosephVolosin
had a problem deploying
to
test-workflow
December 4, 2024 15:16 — with
GitHub Actions
Failure
…rces to event types
JosephVolosin
had a problem deploying
to
test-workflow
December 4, 2024 17:16 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
December 4, 2024 17:38 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
December 4, 2024 21:49 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
December 5, 2024 18:05 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
December 10, 2024 14:52 — with
GitHub Actions
Failure
JosephVolosin
had a problem deploying
to
test-workflow
December 11, 2024 21:59 — with
GitHub Actions
Failure
Test lenght is becoming a concern, so tests may be flaky in this commit
JosephVolosin
temporarily deployed
to
test-workflow
December 12, 2024 21:29 — with
GitHub Actions
Inactive
JosephVolosin
temporarily deployed
to
test-workflow
December 13, 2024 15:16 — with
GitHub Actions
Inactive
JosephVolosin
temporarily deployed
to
test-workflow
December 13, 2024 19:04 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
___REQUIRES_AERIE_PR___="1606"
___REQUIRES_GATEWAY_PR___="116"
Description
This PR adds external source and event attribute validation to AERIE.
It is explained more in depth here.
The main updates to the UI for this PR surround the displaying of source and event attributes in the UI, namely in the External Source Manager, as well as an external source/event type creation page (previously Modals). Derivation group creation has presently been moved out of a modal and is delegated to the
Derivation Group
field where sources are uploaded.Below is a view of the new 'External Types Manager' with an External Source Type's attribute schema being shown:
Below is a view of an External Event's attributes being shown:
Walkthrough
Upload
To use this feature, navigate to the
External Sources
page of AerieSelect the
Types
button in the top-right to switch to the/types
sub-page.Click the 'Choose File' button and select a complete External Source & Event type schema (see bottom of this section for an example file). The pane should display the External Source & Event types that will be created once the 'Upload' button has been clicked - click the 'Upload' button to submit & create the types.
After the types have been created, a source can be uploaded by clicking the
Sources
button in the top-right, then selecting theChoose File
button in the left-pane, selecting the related External Source, and clickingUpload
.Viewing Schemas
The attribute schema for an uploaded External Event or Source Type can be viewed by navigating to the
External Sources
page and selecting theTypes
button in the top-right to switch to the/types
sub-page.Once on the
Types
page, select the tab for the desired type (Event
orSource
) and then hover the row containing the desired type. Click theView
button that appears. On the left-pane, the type should be displayed with two collapsible categories forAttribute Schema - Definition
andAttribute Schema - Properties
.Definition
contains any top-level fields included other thanProperties
, which is shown under the other collapse.Viewing Attributes
The attributes of a given External Source or Event can be seen by navigating to the
External Sources
page, hovering over the row for the desired External Source, and clicking theView
button. In theSelected External Source
pane on the left, there is a section forAttributes
which when clicked will show the specific attributes for the given source.Example Files
Example External Source Schema:
Schema_Example_Source.json
Example External Source: ExampleExternalSource.json