Fix pgcmp workflow #1545
Merged
Fix pgcmp workflow #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mythicaeda
force-pushed
the
fix/pgcmp-workflow
branch
from
e505c73 to
a852137
Compare
Mythicaeda
force-pushed
the
fix/pgcmp-workflow
branch
from
a852137 to
af12a78
Compare
dandelany
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
This looks correct to me now, I agree with the change in compareDatabasesUp.sh & I'm surprised it didn't complain about the incorrect path before. Approved pending expected failure of the workflow to validate the broken migration.
|
This PR didn't run the https://github.com/NASA-AMMOS/aerie/actions/runs/10710079763 This is the failure we expected to see, indicating this is 👍 to merge. |
Mythicaeda
force-pushed
the
fix/pgcmp-workflow
branch
from
af12a78 to
95e4328
Compare
Mythicaeda
force-pushed
the
fix/pgcmp-workflow
branch
from
95e4328 to
07bf79a
Compare
This is what the files are called when the artifacts are downloaded outside of the workflow.
Mythicaeda
force-pushed
the
fix/pgcmp-workflow
branch
from
07bf79a to
08bbcb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our db comparison workflow is failing to catch errors it should. Testing the
pgcmptool against the dumps manually, however, revealed that the issue is likely in the workflow itself rather than the tool, as the tool is correctly spotting the errors locally.Workflow run proving the up is now working
Verification
The workflow failing with the correct comparison failure will be a success, as currently
develophas an inconsitency in migration 9 (fix PR for that is here)