Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook workspace fk up to the correct table in migration #1544

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Hook workspace fk up to the correct table in migration #1544

merged 1 commit into from
Sep 4, 2024

Conversation

Mythicaeda
Copy link
Contributor

  • Tickets addressed: AERIE-000
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

There was a typo in migration 9 that added an fk to the parcel table instead of the workspace table.

Verification

I have confirmed that the code is now an exact match to the files updated.

Documentation

Future work

Investigate how this wasn't caught by our automated dbcmp tests.

@Mythicaeda Mythicaeda added fix A bug fix database Anything related to the database labels Sep 4, 2024
@Mythicaeda Mythicaeda self-assigned this Sep 4, 2024
@Mythicaeda Mythicaeda requested a review from a team as a code owner September 4, 2024 19:20
cohansen
cohansen approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@cohansen cohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as checks pass, g2g.

@Mythicaeda
Copy link
Contributor Author

As long as checks pass, g2g.

The thing is, the checks passed initially somehow 🫠

@Mythicaeda Mythicaeda mentioned this pull request Sep 4, 2024
Merged
@Mythicaeda Mythicaeda merged commit f6271f2 into develop Sep 4, 2024
22 checks passed
@Mythicaeda Mythicaeda deleted the fix/migration-typo branch September 4, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cohansen cohansen cohansen approved these changes

@skovati skovati Awaiting requested review from skovati

Assignees

@Mythicaeda Mythicaeda

Labels
database Anything related to the database fix A bug fix
Projects
Aerie
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mythicaeda @cohansen