-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the backend for sequencing workspaces #1526
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cohansen
force-pushed
the
feature/sequence-workspaces
branch
from
August 8, 2024 21:39
95ef307
to
3709d65
Compare
goetzrrGit
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything that sticks out as concerning. Maybe get @Mythicaeda to do a quick pass just to see if anything sticks out to her.
deployment/hasura/metadata/databases/tables/sequencing/user_sequence.yaml
Outdated
Show resolved
Hide resolved
Mythicaeda
reviewed
Aug 22, 2024
deployment/hasura/metadata/databases/tables/sequencing/user_sequence.yaml
Outdated
Show resolved
Hide resolved
deployment/hasura/metadata/databases/tables/sequencing/workspace.yaml
Outdated
Show resolved
Hide resolved
Mythicaeda
reviewed
Aug 22, 2024
deployment/postgres-init-db/sql/tables/sequencing/workspace.sql
Outdated
Show resolved
Hide resolved
Mythicaeda
approved these changes
Aug 29, 2024
…to not null and other pr feedback
cohansen
force-pushed
the
feature/sequence-workspaces
branch
from
August 30, 2024 17:39
9208478
to
a4c2b18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Front-end PR: NASA-AMMOS/aerie-ui#1420
Description
Adds backend support for sequence workspaces. Migration includes creating a workspace and adding every existing sequence to that created workspace.
Verification
Manually tested.
Documentation
NA
Future work
These will be improved in the future, right now we're only allowing 1 level deep.