Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the backend for sequencing workspaces #1526

Merged
merged 6 commits into from
Aug 30, 2024

Conversation

cohansen
Copy link
Contributor

@cohansen cohansen commented Aug 7, 2024

  • Tickets addressed: #1393
  • Review: By commit
  • Merge strategy: Merge (no squash)

Front-end PR: NASA-AMMOS/aerie-ui#1420

Description

Adds backend support for sequence workspaces. Migration includes creating a workspace and adding every existing sequence to that created workspace.

Verification

Manually tested.

Documentation

NA

Future work

These will be improved in the future, right now we're only allowing 1 level deep.

@cohansen cohansen self-assigned this Aug 7, 2024
@cohansen cohansen requested a review from a team as a code owner August 7, 2024 22:35
@cohansen cohansen force-pushed the feature/sequence-workspaces branch from 95ef307 to 3709d65 Compare August 8, 2024 21:39
Copy link
Contributor

@goetzrrGit goetzrrGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything that sticks out as concerning. Maybe get @Mythicaeda to do a quick pass just to see if anything sticks out to her.

@dandelany dandelany added the publish Tells GH to publish docker images for this PR label Aug 29, 2024
@cohansen cohansen force-pushed the feature/sequence-workspaces branch from 9208478 to a4c2b18 Compare August 30, 2024 17:39
@cohansen cohansen merged commit a2352ae into develop Aug 30, 2024
25 of 26 checks passed
@cohansen cohansen deleted the feature/sequence-workspaces branch August 30, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DON'T MERGE Do Not Merge This Branch publish Tells GH to publish docker images for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants