-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sequence workspaces #1420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cohansen
had a problem deploying
to
test-workflow
August 7, 2024 22:39 — with
GitHub Actions
Failure
cohansen
had a problem deploying
to
test-workflow
August 8, 2024 00:56 — with
GitHub Actions
Failure
duranb
reviewed
Aug 14, 2024
duranb
reviewed
Aug 14, 2024
duranb
reviewed
Aug 14, 2024
duranb
reviewed
Aug 15, 2024
cohansen
force-pushed
the
feature/sequence-workspaces
branch
from
August 16, 2024 16:25
b684675
to
65a2e93
Compare
cohansen
had a problem deploying
to
test-workflow
August 16, 2024 16:25 — with
GitHub Actions
Failure
cohansen
force-pushed
the
feature/sequence-workspaces
branch
from
August 21, 2024 19:50
cfcd13b
to
2ddc536
Compare
cohansen
had a problem deploying
to
test-workflow
August 21, 2024 19:50 — with
GitHub Actions
Failure
dandelany
temporarily deployed
to
test-workflow
August 29, 2024 00:44 — with
GitHub Actions
Inactive
duranb
force-pushed
the
feature/sequence-workspaces
branch
from
August 29, 2024 17:09
2ddc536
to
2576f0f
Compare
duranb
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after NASA-AMMOS/aerie#1526 is merged in, this looks good to go! thanks!
…he sequencing page to break
cohansen
force-pushed
the
feature/sequence-workspaces
branch
from
August 30, 2024 18:01
2576f0f
to
f4d4704
Compare
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Refactored the sequence table into its own component * Rough prototype of workspaces * Added the sequence header back in * More workspace improvements, navigation and persistance working now * Added a modal to set and edit workspace names * Added the workspace name to the top of the sequence table * Added a uniqueness check for workspace names * Added a e2e test for workspaces * Changed how the workspace test functions * Fixed an issue where browser code was running on the server causing the sequencing page to break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
___REQUIRES_AERIE_PR___="1526"
Closes #1393.
Adds sequence workspaces, including unique name checking and an updated sequences page.
Backend PR: NASA-AMMOS/aerie#1526