Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sequence workspaces #1420

Merged
merged 10 commits into from
Aug 30, 2024
Merged

Feature/sequence workspaces #1420

merged 10 commits into from
Aug 30, 2024

Conversation

cohansen
Copy link
Contributor

@cohansen cohansen commented Aug 7, 2024

___REQUIRES_AERIE_PR___="1526"

Closes #1393.

Adds sequence workspaces, including unique name checking and an updated sequences page.

Backend PR: NASA-AMMOS/aerie#1526

@cohansen cohansen force-pushed the feature/sequence-workspaces branch from b684675 to 65a2e93 Compare August 16, 2024 16:25
@cohansen cohansen force-pushed the feature/sequence-workspaces branch from cfcd13b to 2ddc536 Compare August 21, 2024 19:50
@dandelany
Copy link
Collaborator

FYI @cohansen I've updated this PR to test with the backend PR using the method from #1439 and tests are now passing 👏 🎉

@duranb duranb force-pushed the feature/sequence-workspaces branch from 2ddc536 to 2576f0f Compare August 29, 2024 17:09
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after NASA-AMMOS/aerie#1526 is merged in, this looks good to go! thanks!

@cohansen cohansen force-pushed the feature/sequence-workspaces branch from 2576f0f to f4d4704 Compare August 30, 2024 18:01
@cohansen cohansen merged commit 0af6fc4 into develop Aug 30, 2024
5 checks passed
@cohansen cohansen deleted the feature/sequence-workspaces branch August 30, 2024 19:04
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* Refactored the sequence table into its own component

* Rough prototype of workspaces

* Added the sequence header back in

* More workspace improvements, navigation and persistance working now

* Added a modal to set and edit workspace names

* Added the workspace name to the top of the sequence table

* Added a uniqueness check for workspace names

* Added a e2e test for workspaces

* Changed how the workspace test functions

* Fixed an issue where browser code was running on the server causing the sequencing page to break
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phoenix: Add directory-like organization for sequences
3 participants