-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library Sequences from Workspace #1539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're trying too hard to make the VariableDeclaration
work with the existing components. In order to make these components more reusable, we should remove the concepts of "args" and "dictionaries" from them and have the parent component pass in what's necessary. For example, for EnumEditor
, we should not be deriving the options from the definition, but rather passing in an array of options as a prop.
7d19644
to
2a026af
Compare
6804292
to
a7fbe90
Compare
a7fbe90
to
7cdfd55
Compare
7cdfd55
to
f585861
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing my feedback.
f585861
to
6cc1208
Compare
6cc1208
to
a66110d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
* Using the workspace_id all sequences in a workspace are library sequences. * Pass this list of library sequences along to the different parts of codemirror etc. linter, autocomplete, SelectedCommand Panel.
* The linter will typechecking the library sequences parameters/arguments
2bbf772
to
2e0da76
Compare
This pull request introduces support for library sequences, which allow users to use sequences within their workspaces. Closes #1501
Key Changes:
WorkspaceID Passthrough: The workspaceID is now passed to the SequenceEditor, enabling it to work with sequences from the selected workspace.
Library Sequence Library Type: A new library sequence type has been created, and the Adaptation object has been updated accordingly.
Workspace Sequence Mapping: All sequences in the selected workspace are automatically recognized as library sequences.
Linter Integration: The linter now checks the syntax and semantics of library sequence arguments.
Selected Command Panel Enhancements: The Selected Command panel now displays
load
andactivate
arguments for library sequences.Autocompletion Support: Autocompletion is available for library sequence identifiers.
How to test
SeqA
with the below contentSeqB
in the same workspace@ACTIVATE
or@LOAD,
autocomplete should appear for theseDirectives
SeqA
as an option