Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduling jar upload #1444

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Scheduling jar upload #1444

merged 5 commits into from
Sep 9, 2024

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Aug 29, 2024

Resolves #1436

To test:

  1. Navigate to http://localhost:3000/scheduling/goals/new
  2. Fill out the name for the goal
  3. Select "JAR File" to display the file input field
  4. Select the example procedure file at /e2e-tests/data/example-procedure.jar
  5. Verify that the code editor is no longer viewable
  6. Finish filling out the rest of the goal's fields as desired
  7. Click the "Save" button
  8. Verify that the goal was successfully created

@duranb duranb force-pushed the feature/scheduling-upload branch from abc494e to 4acea83 Compare August 29, 2024 23:43
@skovati skovati force-pushed the feature/procedural-scheduling branch from 47cc3cf to 513e98d Compare September 3, 2024 17:37
@duranb duranb force-pushed the feature/scheduling-upload branch from 4acea83 to 0caaf5b Compare September 3, 2024 17:39
@skovati skovati force-pushed the feature/procedural-scheduling branch from 513e98d to e9b41dc Compare September 3, 2024 18:00
@duranb duranb force-pushed the feature/scheduling-upload branch from 0caaf5b to 0459a67 Compare September 3, 2024 19:53
@skovati skovati force-pushed the feature/procedural-scheduling branch 2 times, most recently from 74cd3fa to b93ad1d Compare September 4, 2024 23:09
@duranb duranb force-pushed the feature/scheduling-upload branch from c81fb06 to 6d8d031 Compare September 5, 2024 19:49
@duranb duranb marked this pull request as ready for review September 5, 2024 19:51
@duranb duranb requested a review from a team as a code owner September 5, 2024 19:51
@duranb duranb changed the base branch from feature/procedural-scheduling to develop September 5, 2024 19:59
@duranb duranb added the DON'T MERGE Do Not Merge This Branch label Sep 5, 2024
Copy link
Collaborator

@dandelany dandelany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🎉 I've reviewed the code & tested locally thoroughly with a few procedural JARs. Ready to merge after backend.

@duranb duranb force-pushed the feature/scheduling-upload branch from eeab686 to a9cbeb2 Compare September 9, 2024 23:25
@skovati
Copy link
Contributor

skovati commented Sep 9, 2024

Make sure we're testing against the develop images now

@duranb duranb merged commit 22ce741 into develop Sep 9, 2024
7 checks passed
@duranb duranb deleted the feature/scheduling-upload branch September 9, 2024 23:48
@duranb duranb removed the DON'T MERGE Do Not Merge This Branch label Sep 10, 2024
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* add form element to specify file upload for scheduling goals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVP UI for uploading scheduling procedures
4 participants