follow insert/set naming convention now that update doesn't use the i…

…nput type
NASA-AMMOS · Sep 4, 2024 · b93ad1d · b93ad1d
1 parent d79cb98
commit b93ad1d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/types/scheduling.ts b/src/types/scheduling.ts
@@ -99,10 +99,8 @@ export type SchedulingGoalInsertInput = Omit<
 };
 
 export type SchedulingConditionPlanSpecInsertInput = Omit<SchedulingConditionPlanSpecification, 'condition_metadata'>;
-export type SchedulingGoalPlanSpecInsertInput = Omit<SchedulingGoalPlanSpecification, 'goal_metadata'>;
-
-// omit goal_invocation_id since DB will set it when inserting a new invocation
-export type SchedulingGoalPlanSpecInvocationInsertInput = Omit<SchedulingGoalPlanSpecInsertInput, 'goal_invocation_id'>;
+export type SchedulingGoalPlanSpecSetInput = Omit<SchedulingGoalPlanSpecification, 'goal_metadata'>;
+export type SchedulingGoalPlanSpecInsertInput = Omit<SchedulingGoalPlanSpecSetInput, 'goal_invocation_id'>;
 
 export type SchedulingConditionMetadataSetInput = PartialWith<SchedulingConditionMetadata, 'owner'>;
 export type SchedulingGoalMetadataSetInput = PartialWith<SchedulingGoalMetadata, 'owner'>;

diff --git a/src/utilities/effects.ts b/src/utilities/effects.ts
@@ -128,7 +128,7 @@ import type {
   SchedulingGoalModelSpecificationInsertInput,
   SchedulingGoalModelSpecificationSetInput,
   SchedulingGoalPlanSpecInsertInput,
-  SchedulingGoalPlanSpecInvocationInsertInput,
+  SchedulingGoalPlanSpecSetInput,
   SchedulingGoalPlanSpecification,
   SchedulingPlanSpecification,
   SchedulingPlanSpecificationInsertInput,
@@ -1422,7 +1422,7 @@ const effects = {
   },
 
   async createSchedulingGoalPlanSpecification(
-    spec_goal: SchedulingGoalPlanSpecInvocationInsertInput,
+    spec_goal: SchedulingGoalPlanSpecInsertInput,
     user: User | null,
   ): Promise<number | null> {
     try {
@@ -5376,7 +5376,7 @@ const effects = {
 
   async updateSchedulingGoalPlanSpecification(
     plan: Plan,
-    schedulingGoalPlanSpecification: SchedulingGoalPlanSpecInsertInput,
+    schedulingGoalPlanSpecification: SchedulingGoalPlanSpecSetInput,
     user: User | null,
   ) {
     try {