MVP Procedural Scheduling UI #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skovati
force-pushed
the
feature/procedural-scheduling
branch
from
39265c0 to
1d21749
Compare
skovati
had a problem deploying
to
test-workflow
GitHub Actions
Failure
duranb
reviewed
Aug 20, 2024
duranb
reviewed
Aug 21, 2024
skovati
had a problem deploying
to
test-workflow
GitHub Actions
Failure
skovati
force-pushed
the
feature/procedural-scheduling
branch
from
1f3f5ab to
ab015f5
Compare
skovati
had a problem deploying
to
test-workflow
GitHub Actions
Failure
skovati
had a problem deploying
to
test-workflow
GitHub Actions
Failure
skovati
had a problem deploying
to
test-workflow
GitHub Actions
Failure
skovati
had a problem deploying
to
test-workflow
GitHub Actions
Failure
skovati
had a problem deploying
to
test-workflow
GitHub Actions
Failure
skovati
had a problem deploying
to
test-workflow
GitHub Actions
Failure
skovati
had a problem deploying
to
test-workflow
GitHub Actions
Failure
skovati
had a problem deploying
to
test-workflow
GitHub Actions
Failure
skovati
force-pushed
the
feature/procedural-scheduling
branch
from
395977c to
65167bc
Compare
skovati
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
had a problem deploying
to
test-workflow
GitHub Actions
Failure
mattdailis
had a problem deploying
to
test-workflow
GitHub Actions
Failure
mattdailis
had a problem deploying
to
test-workflow
GitHub Actions
Failure
two part fix:
- `allowedSchedulingGoalSpecs` was really an array, but was treated as an object
- use `find` instead of indexing with `goal_id`
- remove owner check, since that was always being triggered as true,
causing an update
- this extranous update was fine before, since the upsert would
handle the deduplication, but now with goal invocations, where we
allow duplicates, it was causing random duplications of goals when
exiting the modal
skovati
force-pushed
the
feature/procedural-scheduling
branch
from
74cd3fa to
b93ad1d
Compare
skovati
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
dandelany
approved these changes
Sep 9, 2024
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Prototype for showing parameters for scheduling procedures
* Add support for scheduling goal invocations
* fix revision bug
* wip goal invocation PK change
* fix scheduling goal page bug for non-procedural goals
* fix linting errors
* move `type` field from `BaseDefinition` to `SchedulingGoalDefinition`
* Clean up SchedulingGoal.svelte with small suggestions
* run prettier
* oh eslint you are so picky
* fix svelte check errors
* run prettier
* follow pattern of filtering allowed goal invocations
* use `Queries.SCHEDULING_SPECIFICATION_GOALS` enum
* run prettier
* fix duplicate invocation bug when exiting the goal management modal
two part fix:
- `allowedSchedulingGoalSpecs` was really an array, but was treated as an object
- use `find` instead of indexing with `goal_id`
- remove owner check, since that was always being triggered as true,
causing an update
- this extranous update was fine before, since the upsert would
handle the deduplication, but now with goal invocations, where we
allow duplicates, it was causing random duplications of goals when
exiting the modal
* make eslint and prettier happy
* remove console.log
* remove unnecessary mutable result variable
* remove redundant invocation stores
* add type to plan spec mega query
* add new effect for creating goal invocation
* remove on_conflict from `updateSchedulingGoalPlanSpecifications`
* run prettier
* add new invocation insert type that omits `goal_invocation_id`
* follow insert/set naming convention now that update doesn't use the input type
---------
Co-authored-by: Matthew Dailis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
___REQUIRES_AERIE_PR___="1496"NASA-AMMOS/aerie#1496
Adds a few small UI features in the scheduling goals panel that add additional functionality (arguments, duplicating goal invocations) when dealing with procedures instead of EDSL goals.
As part of the procedural scheduling backend changes, the primary key for
scheduling_specification_goalsis a new (auto-generated)goal_invocation_idint. This PR also updates a few functions / GQL queries to use this ID instead of(spec, goal_id, revision)when possible